Dont re-pin total_seconds as it is already implemented #17432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17432 +/- ##
==========================================
- Coverage 91.15% 91.14% -0.02%
==========================================
Files 163 163
Lines 49581 49581
==========================================
- Hits 45198 45190 -8
- Misses 4383 4391 +8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17432 +/- ##
==========================================
- Coverage 91.15% 91.14% -0.02%
==========================================
Files 163 163
Lines 49581 49581
==========================================
- Hits 45198 45190 -8
- Misses 4383 4391 +8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17432 +/- ##
==========================================
- Coverage 91.15% 91.14% -0.02%
==========================================
Files 163 163
Lines 49587 49587
==========================================
- Hits 45203 45194 -9
- Misses 4384 4393 +9
Continue to review full report at Codecov.
|
gfyoung
added
Clean
Internals
| @@ -3892,8 +3892,9 @@ for field in fields: | |||
| _nat_methods = ['date', 'now', 'replace', 'to_pydatetime', | |||
| 'today', 'round', 'floor', 'ceil', 'tz_convert', | |||
| 'tz_localize'] | |||
| _nan_methods = ['weekday', 'isoweekday', 'total_seconds'] | |||
| _implemented_methods = ['to_datetime', 'to_datetime64', 'isoformat'] | |||
| _nan_methods = ['weekday', 'isoweekday'] | |||
There was a problem hiding this comment.
This blows away the doc-string. So I would rather leave this as-is and simply remove the total_seconds method from NaT class; accomplishing the same thing more in-line with current code.
There was a problem hiding this comment.
Fair enough. I defaulted to leaving the def total_seconds in place because it had a GH issue attached to it. Can change, or can just pin on the correct docstring up where the method is defined.
There was a problem hiding this comment.
see my comments, its would be faster just to make the change.
| @@ -3892,8 +3892,9 @@ for field in fields: | |||
| _nat_methods = ['date', 'now', 'replace', 'to_pydatetime', | |||
| 'today', 'round', 'floor', 'ceil', 'tz_convert', | |||
| 'tz_localize'] | |||
| _nan_methods = ['weekday', 'isoweekday', 'total_seconds'] | |||
| _implemented_methods = ['to_datetime', 'to_datetime64', 'isoformat'] | |||
| _nan_methods = ['weekday', 'isoweekday'] | |||
There was a problem hiding this comment.
see my comments, its would be faster just to make the change.
|
Just pushed commit to follow your suggestion. |
jbrockmendel
force-pushed
the
dedup_total_seconds
branch
from
5c1494c to
4d7f6f2
Compare
|
Nope, turns out defining |
|
thanks |
git diff upstream/master -u -- "*.py" | flake8 --diff